MVSFORUMS.com

rasprasads · Posted: Fri Feb 06, 2004 7:52 am Post subject:

The performance is affected by large data processing. I changed the code to check from the end of line to first as the occurunce of this will be at the end. There was a slight improvement in performance. Any other ideas to improve the performance ?
_________________
Rasprasad S

Mike Chantrey · Posted: Fri Feb 06, 2004 9:03 am Post subject:

The example uses subscripts. You will probably get at least some (and maybe quite a lot of) performance improvement using indexes instead. Also, you should probably be specifying OPTIMIZE, TRUNC(OPT) and NOSSR compiler options (or the equivalent for your compiler - these are COBOL II).

rasprasads · Posted: Fri Feb 06, 2004 9:24 am Post subject:

Mike, Do you suggest to use a array. I do not get what you mean by Index. Please explain.
_________________
Rasprasad S

Mike Chantrey · Posted: Fri Feb 06, 2004 10:14 am Post subject:

You can define your character strings as indexed arrays, i.e. PIC X OCCURS nnn INDEXED by INDEX-NAME.
I slightly misunderstood the sample code because it was using names like 'WS-SUB' so I thought it was using subscripting but in fact it's using reference modification (as per the :1 stuff). So you may not benefit much from indexing; I've never compared it with ref mod. Also you can't directly replace the :4 ref mod with an index use. So maybe it's not worth trying.
But I'd certainly give the compiler options a go.

Mike Chantrey · Posted: Fri Feb 06, 2004 10:23 am Post subject:

Also, I think the following code from kolusu's example could be changed from

kolusu · Posted: Fri Feb 06, 2004 10:57 am Post subject:

Mike,

I like constructive criticism and thanks for the tip of trimming my code. As you said the code posted earlier is clear and easier to UNDERSTAND as well as to maintain. I agree that Initialize is unnecessary, but it is just me who wants every field clean before manipulating them.

Actually you can clean up some more fields. You really don't need ws-pos1 & ws-pos2 and ws-num.

The perform should always start from position 1 unless you move the first 5 bytes to the output string before the perform loop. This is a case when the first occurance is a match.

Modified code